Applied Energistics 2

Applied Energistics 2

137M Downloads

Charger does not accept oredict certus quartz

DBotThePony opened this issue ยท 6 comments

commented

Describe the bug

Title

To Reproduce

  • Install gregtech-ce, ae2 and crafttweaker
  • Put a crafttweaker script in scripts/ directory with following contents
#modloaded gregtech appliedenergistics2

<ore:crystalCertusQuartz>.addAll(<ore:gemCertusQuartz>);
<ore:crystalNetherQuartz>.addAll(<ore:gemNetherQuartz>);
  • Create a creative world
  • Place the charger and try to put certus quartz from gregtechce into charger
  • You can not do so.

Also, you guys really need to make another way of making charged certus quartz without charger, like 8 redstone + certus quartz to get first charged certus quartz since gregtech-ce adds all known ores (and doesn't contain charged certus quartz ore in worldgen), and every other mod needs to have it's worldgen disabled to prevent ore overlap

Expected behavior

You can put certus quartz into charger

Additional context

screnshot

Environment

  • Server?: yes
  • Minecraft Version: 1.12.2
  • AE2 Version: Revision 6 Stable 4
  • Forge Version: Build 2796
commented

It is nowhere stated, that adding random oredict entries make it work magically. There is an API endpoint available in case mods want to register new items for it.

commented

But isn't charging quartz is supposed to be oredicted? And even if there is an API endpoint, it is not present in crafttweaker
screenshot

commented

Nope, it is hardcoded ๐Ÿ‘ https://github.com/AppliedEnergistics/Applied-Energistics-2/blob/rv6-1.12/src/main/java/appeng/tile/misc/TileCharger.java#L301

can't belive you close issues without actual check like raoul with his refined storage do. and i switched from refined storage to ae2 because of this, and you guys do the same?

commented
commented

I can't resolve dependencies, so i can't setupDecompWorkspace/compile the mod - http://www.isitblockedinrussia.com/?host=mobiusstrip.eu

It is up to @yueh to implement the fix.

commented

If you'd followed the code a bit further, you'd encountered IAEItemPowerStorage. That as well as the charger registry should be enough for mods to implement their own chargable items. Might not be as straightforward as it could be, but it is there.

Charging certus is more or less just an edge case for the charger and there wasn't a single request in the last 4 years or so to allow it to convert basic itemstacks. Doing it now is simply a waste of time and effort. It will need an API break as well as having to throw it away when porting to 1.13/1.14.

Also as fyi, the whole CT is pretty much temporary as vanilla/forge itself is not sufficient for our needs.
Once vanilla/forge is enough, it will be removed (so pretty much guaranteed in 1.13)