Applied Energistics 2

Applied Energistics 2

156M Downloads

Issues with Canvas Renderer

DariusSG opened this issue · 10 comments

commented

Describe the bug
Textures that are dynamic such as cables and facades don't renderer.

To Reproduce
Include Canvas Renderer

Expected behavior
Well, everything should render.

Additional context
2020-08-27_18 32 00

https://pastebin.com/YPe26NiR

Without Canvas
2020-08-27_18 39 14

https://pastebin.com/RXQf9r0M

commented

There is at least one open issue with canvas right now that will need to be merged before we can fix this.

However, rest assured, canvas compat is planned.

commented

I should have looked before I posted this one: #4657

There are the two lines to remove we saw earlier, but that will also need to be addressed. Otherwise, everything from my end is ready to go AFAIK.

commented

With the following combination of versions:

[✔️] appliedenergistics2-fabric-8.1.0-alpha.7
[✔️] canvas-mc116-1.0.927
[✔️] fabric-api-0.20.1+build.401-1.16

I get the normal loading screen, but when it fades away the client looks very messed up:

screenshot1

commented

A little further testing of different version reveals that this is caused by the combination of the new Canvas renderer version and AE2. Downgrading Canvas Renderer to one release earlier (canvas-mc116-1.0.878) fixes this issue, but shows the old behaviour of cables and some other AE2 stuff not getting rendered.

commented

@petabyteboy weird. I did test this yesterday with AE2 alpha.7, and canvas 913, which worked for me.
i did not test it with canvas 927. are you sure that is not a canvas problem?

commented

I see there is an issue for this in the Canvas repo and you even found it already: vram-guild/canvas#100

If it works with canvas 913, it might very well be an issue in the canvas code. I will try to bisect the commits in canvas to find the change that broke it.

commented

Nope, the main menu is borked with canvas 913 + AE2 alpha.7 as well.

commented

This should be fixed in Canvas build 929, available now on CF.

commented

I can confirm that it works fine. Thanks everyone for the great work 👍
One last nitpick: The ME Drive indicators are constantly flashing around when I move. Maybe they are rendered at the same depth as the background and the order is not always the same with Canvas?

commented

It is probably z-fighting, yes, I did observe something similar.
For now I'll leave it at that. Once our sizable backlog has been reduced somewhat I'll look at making actual canvas-specific improvements and fixes (such as making AE2 lights glow).