Applied Energistics 2

Applied Energistics 2

Mods
137M Downloads

AE Compass Service prevents VM termination

sfPlayer1 opened this issue ยท 3 comments

commented

Applied-Energistics-2/src/main/java/appeng/services/compass/CompassThreadFactory.java

Line 37 in 5225ea4

return new Thread(job, "AE Compass Service");
doesn't use Thread.setDaemon(true), leading to a non-daemon thread that will prevent MC from shutting down from an exception. As there is no way to orderly terminate the thread within a crash, making all auxiliary threads daemon threads is the only adequate solution.

commented

Thanks, I would assume this would also apply here

Applied-Energistics-2/src/main/java/appeng/me/cache/CraftingGridCache.java

Lines 99 to 101 in b8e53ad

final ThreadFactory factory = ar -> new Thread(ar, "AE Crafting Calculator");
CRAFTING_POOL = Executors.newCachedThreadPool(factory);

commented

Yes, same easy fix

commented

While you are at it, setUncaughtExceptionHandler is always a good idea, just in case an exception slips through and otherwise ruins your day by becoming invisible.