Applied Energistics 2

Applied Energistics 2

156M Downloads

Drop `appeng.api.parts.PartItemStack`

yueh opened this issue ยท 3 comments

commented

This is currently overlapping with a couple other methods or will be with other planned changes

  • BREAK and WRENCH should be rolled into IPart#getDrops(). See #5169 for further details
  • PICK should be provided by something like IPart#getPickBlock similar to Block#getPickBlock()
  • WORLD and NETWORK are more of an internal case and are probably obsolete with the changes in #5170.
commented

What return type would you consider for getPickBlock? Parts usually don't have blocks.

commented

by vanilla behaviour i would say return the itemstack of the part that is under the cursor (at least this is what i see ender io doing)

commented

Just like currently the item. I guess we can argue about the the name and potentially call it IPart#getPickPart() or something. Vanilla also returns an itemstack and calls it pickBlock (or at least mcp. no idea how the official mapping is)