Applied Energistics 2

The null checks for node.getGrid() in IManagedGridNode are useless: getGrid will never return a null grid.

No:

Applied-Energistics-2/src/main/java/appeng/me/GridNode.java

Lines 279 to 285 in 2760f4e

    
           @Override 
        
           public IGrid getGrid() { 
        
               if (this.myGrid == null) { 
        
                   throw new IllegalStateException("A node is being used after it has been destroyed."); 
        
               } 
        
               return this.myGrid; 
        
           }

Is it possible that this happens after/while destroying the grid?

A nice, then you are fully correct, i think I added the IllegalStateException later

…

On Fri, Nov 26, 2021 at 4:12 PM Technici4n ***@***.***> wrote: No: https://github.com/AppliedEnergistics/Applied-Energistics-2/blob/2760f4ededd3fe72a7c445fa49f739f9d26b89d1/src/main/java/appeng/me/GridNode.java#L279-L285 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5710 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJT6VZE2LJOA3YFNCJERCLUN6PV5ANCNFSM5IZIY2TA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

Yeah, this is the kind of assumptions that are very hard to deal with... Only after extensive testing can we say that it's indeed safe to throw the exception...

	@Override
	public IGrid getGrid() {
	if (this.myGrid == null) {
	throw new IllegalStateException("A node is being used after it has been destroyed.");
	}
	return this.myGrid;
	}

Share to