Starting a crafting task in the wireless crafting terminal (when in a trinket slot) does not return to the terminal screen
ramidzkh opened this issue · 6 comments
Describe the bug
Starting a crafting task in the wireless crafting terminal (when in a trinket slot) does not return to the terminal screen once queued. The simulation screen however is updated in whether there are available crafting CPUs available (as the task is actually queued)
How to reproduce the bug
- Acquire a wireless crafting terminal
- Equip it in a trinket slot
- Try queuing a craft
- Start after the craft has been simulated
Expected behavior
The screen will return to the normal wireless crafting terminal screen once queued
Additional details
No response
Which minecraft version are you using?
1.18
On which mod loaders does it happen?
Fabric
Crash log
N/A
I am not 100% sure we can fix this, as I am not sure how trinkets are even stored/persisted.
I'd probably have to colab with @Mari023 to add support for it. I am not even sure how the GUI opens in the first place 😅
Are the trinket slots represented as normal inventory slots in the player inventory? If so, then the MenuLocator with player+inv should just work, in theory at least.
I think trinkets are only accessible through their api, and I think they don't even have numbers, just String identifiers.
I currently mixin into MenuTypeBuilder#getHostFromPlayerInventory and change it, to search the host in Trinkets for slot 100-200
It is somewhat a hack, and I have some ideas on how to do that properly, but that will take some time (and is a different issue)
Anyways, this is a bug in ae2wtlib, so I opened an issue there.
@Mari023 I think we can actually make MenuLocator more generic and extendable