Meteorites generate despite disabling them
dav20011 opened this issue ยท 11 comments
Describe the bug
In the 1.18.1 Forge version the generateMeteorites = false option gets ignored.
How to reproduce the bug
- Create a standard 1.18.1 Forge setup with just AE2 (newest version as shown in the crash report)
- Start and stop the game and disable meteorites in
config/ae2-common.toml - Relaunch the game, create a new world and look for a meteorite
- Example: Use the world seed
-941960200960353326, then execute/tp -1954 76 -504
Expected behavior
There should be no meteorites in the world.
Additional details
No response
Which minecraft version are you using?
1.18
On which mod loaders does it happen?
Forge
Crash log
Seems like the equivalent to this was never implemented for the Forge version.
That does not work on Forge. Forge loads configuration files after that the relevant code is run.
That is indeed unfortunate. Maybe a comment that it does not work should do it for now.
But given that the meteorite generation is one of the most critized features of AE2 there should be some way to disable it. There seem to be other ways to register structures like this that work after the config has been loaded.
Yeah there is, it's a bit of a wild west at the moment. That's why I am keeping this issue open.
We have the issue on the other end of the spectrum too, where people want it to generate in Terralith worlds, but it fails because Terralith takes an entirely different codepath.
@Technici4n where is this ae2:has_meteorites biome tag?
This is standard data pack stuff, the tag is contained in the data folder of our JAR file, and you can refer to the Minecraft wiki for details on how to override it with a data pack.