Point meteorite compass to something other than sky stone
62832 opened this issue ยท 5 comments
Describe the feature
With the changes made to meteorites, including the addition of the fluix block core around the chest, it would be nice to amend the meteorite compass to make it point towards either those fluix blocks or the chest itself instead of the sky stone making up the meteorite.
Reasons why it should be considered
Currently, having the meteorite compass point to naturally-generating sky stone from meteorites means it becomes tedious later on to ensure the compass stops pointing at an already-discovered meteorite.
The requirement is currently to mine out all the sky stone on the site of the meteorite to force the compass to point elsewhere, which is an extremely tedious process without an already fast tool or some extra utility mod for vein-mining. This is even worse when the meteorite is on the surface as opposed to underground due to the extra sky stone which, while loosely scattered about the site, still technically counts as part of the meteorite.
Additional details
No response
There is also a bug related to this, I do not know if it still matters after the change:
If after the generation of the meteorite some of the blocks detectable by the compass gets replaced by other mods generation (eg by oil comming from pneumaticcraft) the compass considers the oil as skystones and keeps spinning until you remove the oil or at least replace the oil with e.g. cobble.
From what I glanced of the code while making the change in the linked PR, that shouldn't be the case. At least my impression was that the compass simply looks for the nearest chunk containing specifically a block of sky stone.
In fact, doing some (perhaps limited) testing I found that there is nothing yet present to distinguish between sky stone blocks placed manually by a player and sky stone blocks arising from worldgen in meteorites, and this behaviour would persist for now with the replacement with sky stone chests.
Are you certain that you removed all the sky stone in that chunk prior to also removing the oil? I could of course be very wrong and there could be some further miscalculation brought on by the extra worldgen as you mention.
Yes, I am positive that there were no skystones missed. I especially installed the Scannable Mod to search for the remaining Sky Stones.
Idea from #5875: we could also point to the closest fluix block, to be determined.