Applied Energistics 2

Applied Energistics 2

137M Downloads

Jade Compat

Brittank88 opened this issue ยท 13 comments

commented

Describe the feature

This is quite similar to the compat provided for WAILA, just for Jade.

Reasons why it should be considered

It would be very easy to add support for Jade, as much of the API is the same, in fact, the class names are the same as those from the WAILA API: https://github.com/Snownee/Jade/tree/1.19-fabric/src/main/java/snownee/jade/api

Additional details

This stems from #6445, where I first realised that AE2 doesn't actually support Jade, despite supporting WAILA (and any fork mod that uses its API classes in their original classpath).

commented

I think one thing missing from WTHIT is the block-breaking display present in Jade. Could be wrong though. Will migrate to WTHIT for now.

commented

No, actually we DO support Jade. But only on Forge, since they never had a Fabric version before.
On Fabric, we support WTHIT. https://www.curseforge.com/minecraft/mc-mods/wthit

We have not decided at this point, whether we are going to essentially copy/paste the Jade integration over to Fabric, since WTHIT seems to be sufficient.

commented

Also, if the effort is so minimal that it is basically copy-pasting, I'm not sure why you wouldn't do it just to widen the circle of compatibility? Maybe there's a lot I'm not aware of though.

commented

WTHIT and Jade share 95% of the code and use the same package-name. We primarily develop changes on WTHIT and then simply merge them into the Jade integration when we do the Forge release. This reduced maintenance. By having two almost identical copies at the same time means we have to make the changes twice.

commented

Understood - would be better if Jade kept all the WAILA API stuff in the original class path.

commented

one thing missing from WTHIT is the block-breaking

It's already include in WTHIT.

commented

That's cool, now I just have to get WTHIT working because as soon as I installed it into my pack it crashes on joining the world.

There's one reason why supporting multiple similar solutions is a good idea, at least! ๐Ÿ˜›

commented

Understood - would be better if Jade kept all the WAILA API stuff in the original class path.
Well no, because then it'd be completely impossible to support simultaneously, because Jade and WTHIT both made incompatible changes to WAILAs API.

commented

Well no, because then it'd be completely impossible to support simultaneously, because Jade and WTHIT both made incompatible changes to WAILAs API.

Oh huh, I wasn't aware. Glad to learn more!

commented

p.s.: jade on fabric is in the next 1.19 release

commented

Whilst I am super glad that it's coming for 1.19, will it be backported to 1.18.2 as well?

commented

No, use WTHIT + megane for Fabric 1.18.2.

commented

Alright, will do.

Was asking mainly because the AppBot dev said they'd implement more proper Jade support on top of whatever support you provided so I was double checking for them.