Improve Mod Compat for ModelsReloadMixin Hook
shartte opened this issue ยท 5 comments
Some mods may call ModelBakery#getBakedTopLevelModels
, which triggers our post-processing of the baked model map every time the getter is called.
Vanilla calls this method only once, after all models have been baked, from net.minecraft.client.resources.model.ModelManager#apply
. The hook should be moved into that function after the call to the getter.
For reports of incompatibility, see #6462.
hi there, this seems not to work for my server with my modlist. any possibility you would know what this crashlog means? im not really used to reading java/minecraft crashlogs.
thanks for any help you can provide
crash-2022-07-30_18.37.56-server (1).txt
.
hi there, this seems not to work for my server with my modlist. any possibility you would know what this crashlog means? im not really used to reading java/minecraft crashlogs.
thanks for any help you can provide crash-2022-07-30_18.37.56-server (1).txt .
the crashlog has nothing to do with this issue
the issue you have is with collective-fabric, removing collective-fabric should fix it
the crashlog must have something to do with the issue, given when i install this to the server it doesnt want to start.
removing collective-fabric will only make a few mods incompatible it seems.
are you saying that this version of ae2 is just not compatible with collective-fabric?
Check #6426. Your report caused us to take another look at it. As it turns out, this is actually a bug in ae2, which we will fix soon.
Back to this actual issue.
Note to self: Cooking for Blockheads has a better hook at exactly the spot I described above:
https://github.com/ModdingForBlockheads/Balm/blob/d1ee4a3774287a3ffb068b140b56e85dced77cfb/fabric/src/main/java/net/blay09/mods/balm/mixin/ModelManagerMixin.java