Applied Energistics 2

Applied Energistics 2

156M Downloads

Marking a storage cell in a cellworkbench causes it to become unresponsive

klrito123 opened this issue ยท 3 comments

commented

Describe the bug

Set 63 tagged items for the 4k storage cell in the cellworkbench with 1k storage cells, and 63 tagged items for the 16k storage cell with 4k storage cells set with marked items.
When setting up 16k storage cell, the server will stutter and reduce TPS, and the client will not respond.

How to reproduce the bug

Set 63 tagged items for the 4k storage cell in the cellworkbench with 1k storage cells, and 63 tagged items for the 16k storage cell with 4k storage cells set with marked items.
When setting up 16k storage cell, the server will stutter and reduce TPS, and the client will not respond.

Expected behavior

fix this

Additional details

No response

Which minecraft version are you using?

1.18

On which mod loaders does it happen?

Forge

Crash log

https://gist.github.com/klrito123/0b3c6f8bfcd592e8aa956d36b1ae26a2

commented

This is likely due to excessive NBT size

commented

Potential idea to fix this: Prevent setting filters in cells for items that we don't allow to be inserted into cells in the first place.
Since we prevent non-empty storage cells from being inserted, that would fix this bug as well.

commented

We should indeed prevent setting filter items using logic similar to what BasicCellInventory is doing to reject non-empty cells.