Applied Energistics 2

The guidebook says that ammo weight affects damage, but that is untrue. It only affects penetration.
See code:

Applied-Energistics-2/src/main/java/appeng/items/tools/powered/MatterCannonItem.java

Lines 181 to 182 in b271fa3

    
           var ammoStack = itemKey.toStack(); 
        
           var penetration = getPenetration(ammoStack) * shotPower; // 196.96655f;

Applied-Energistics-2/guidebook/items-blocks-machines/matter_cannon.md

Line 18 in b271fa3

    
           depends on the item being fired, with "heavier" items like gold nuggets (10 damage) doing more damage than light items like matter balls (2 damage).

Applied-Energistics-2/src/main/java/appeng/items/tools/powered/MatterCannonItem.java

Lines 347 to 353 in b271fa3

    
           final int dmg = getDamageFromPenetration(penetration); 
        
           if (entityHit instanceof LivingEntity el) { 
        
               penetration -= dmg; 
        
               el.knockback(0, -direction.x, -direction.z); 
        
               // el.knockBack( p, 0, Vector3d.x, 
        
               // Vector3d.z ); 
        
               el.hurt(dmgSrc, dmg);

Applied-Energistics-2/src/main/java/appeng/items/tools/powered/MatterCannonItem.java

Lines 385 to 387 in b271fa3

    
           public static int getDamageFromPenetration(float penetration) { 
        
               return (int) Math.ceil(penetration / 20.0f); 
        
           }

Huh.. I tested this in game with custom ammo (weight of 1000) and that took 20 hits to kill a creeper.

If you compare iron and gold you see a large difference. https://github.com/AppliedEnergistics/Applied-Energistics-2/blob/main/src/main/java/appeng/datagen/providers/recipes/MatterCannonAmmoProvider.java

Huh.. I tested this in game with custom ammo (weight of 1000) and that took 20 hits to kill a creeper.

Are you exaggerating with 20 hits? 👀

Are you exaggerating with 20 hits? 👀

Nope, I counted.
It may of been an issue with the incredibly custom KubeJS scripts I was using to add the ammo recipe, if the weight fields is optional and defaults to 1 damage. I can check tomorrow.

Which version was it on, anyway?

1.20.1

Tried again today.. and it worked?? No idea why it wasn't working before

	var ammoStack = itemKey.toStack();
	var penetration = getPenetration(ammoStack) * shotPower; // 196.96655f;

	final int dmg = getDamageFromPenetration(penetration);
	if (entityHit instanceof LivingEntity el) {
	penetration -= dmg;
	el.knockback(0, -direction.x, -direction.z);
	// el.knockBack( p, 0, Vector3d.x,
	// Vector3d.z );
	el.hurt(dmgSrc, dmg);

	public static int getDamageFromPenetration(float penetration) {
	return (int) Math.ceil(penetration / 20.0f);
	}

Share to