Interface Item Stack Inconsistencies
bryce-happel-walton opened this issue ยท 8 comments
Describe the bug
AE2 Interfaces will cap the item stack limit to what it believes to be the real limit, regardless of the actual limit.
How to reproduce the bug
Install Supplementaries and export shulker shells from an AE2 Interface. Supplementaries makes shulker shells into a wearable helmet, but the inventory stack limit is still 64. AE2 Interfaces will only allow you to export a stack size of 1 instead of 64. You can even pull out stacks from a terminal and interact with them like normal in other user interfaces.
Expected behavior
Export the correct stack size.
Additional details
During testing I encountered another bug. When I disabled Supplementaries, loaded the world and set the interface to export 64, then re-enabled Supplementaries, all the shulker shells were gone. The export was set back to 1, but I couldn't pull anything out and the network did not have the shells that were in the exported when Supplementaries was disabled. I added more shells to the network, then the originals showed up again.
Also I tried to test on Fabric, but Supplementaries does not appear to be working properly. The config option for wearable shulker shells is enabled, but it does not do anything, so I can't test.
Which minecraft version are you using?
1.20.1
On which mod loaders does it happen?
Forge 47.2.20
Neoforge 47.1.99
Crash log
I am sorry can you clarify what you mean by "interface" here?
ME Interfaces, or the user interfaces?
I am sorry can you clarify what you mean by "interface" here?
ME Interfaces, or the user interfaces?
I edited the issue to make it more clear
I don't actually see what you are describing (wearable shulker shells) in the feature list of Quark...
We simply ask the item for its maximum stack size, we do not check for anything else, really.
Please provide the forced-crash report (see the issue template when you create a new issue for instructions), oh and did you try this with just Quark & AE2?
I don't actually see what you are describing (wearable shulker shells) in the feature list of Quark...
We simply ask the item for its maximum stack size, we do not check for anything else, really.
Please provide the forced-crash report (see the issue template when you create a new issue for instructions), oh and did you try this with just Quark & AE2?
Oh you know you're right it's not Quark. I'm playing ATM9 and they added Quark then I had the issue. I don't know exactly which mod it is, but the issue is still present. Is there a way to have different stack sizes for different contexts? You can hold a stack of shells but when you equip it you can only have 1 in the helmet slot. I noticed some of my shells have nbt data too by analyzing with Integrated Dynamics.
I'll investigate further and force a crash.
I updated the issue with more details, a forced crash report, corrections, and modloader versions.
We might have to move to the NBT-aware max stack size methods. (which Fabric previously did not have)
This is indeed a bug because we do not honor the stack-aware method: https://github.com/MehVahdJukaar/Supplementaries/blob/40ed0949b02b0fc82ba35b64a8d7274061dc84ba/forge/src/main/java/net/mehvahdjukaar/supplementaries/common/items/forge/ShulkerShellItem.java#L19. Fixed by #7614.