Applied Energistics 2

Applied Energistics 2

160M Downloads

Wireless Crafting Terminal does not properly consume action on use

shartte opened this issue ยท 2 comments

commented

Tested on Forgecraft, Neoforge 1.20.4

commented

it isn't quite as easy as I thought since ae2 does also check the return value of MenuOpener#open(), which is server only...

tho I don't think there is a case where that would return false when checkPreconditions() is true

commented

I did some testing for this in ae2wtlib,
I think this happens because WirelessTerminalItem#use() always returns new InteractionResultHolder<>(InteractionResult.FAIL, is), when it should probably return new InteractionResultHolder<>(InteractionResult.sidedSuccess(level.isClientSide()), is) (which it does on the server)

this should be an easy fix, since checkPreconditions() is only an item check now, so it can be performed on the client side too