Applied Energistics 2

Applied Energistics 2

172M Downloads

Config to increase meteorite destruction path height limit

Closed this issue ยท 3 comments

commented

Describe the feature

Currently the max destruction path height of meteorites is hard capped at y level 255. It would be nice to change it in the config file.

Specifically I would like to see MeteoritePlacer.java placeCrater() maxY variable exposed to the ae2 common config.

I would probably refactor maxY to something like AEConfig.instance().getMeteoritePathHeightLimit() and add a config for it in that file.

The core issue could probably also be addressed by setting maxY to whatever the minecraft worlds current build height is but I am not as sure on the implementation or compatibility of this.

Reasons why it should be considered

I am not positive if this issue arises typically without world generation mods but with Minecraft's stock build height now at 320 and even more with mods like tectonic that goes to 640. There are often cases where a meteorites destruction path will be abruptly cut off at 255. It would be a lot better if that was configurable in the config file so it can be set to for example 640 when paired with mods that greatly increase the terrain generation height. I am hoping this simple change would be enough to fix the issue.

Additional details

Image
captured with appliedenergistics2-19.2.10

commented

Exposing that as a config is recipe for disaster, imho (as with most worldgen).

Howeeever, we can probably either 1) just use the max build height, 2) make it an option as part of the datapack system

commented

I thought configs would be an easy way but if its not recommended either of those sound good. Making it an option as part of the datapack system is a good idea. I have been using it lately to adjust structure and feature spawn frequency. Frankly though if using the max build height is an elegant solution that doesn't add too much generation time complexity im all for that. I have no clue if it would or would not have much of an impact but i suspect since the build limit is now 319 by default now going to that from 255 shouldn't be that big of a difference if there is any. It would just be nice either way to have a solution that can be modified to support or inherently support non standard build heights like 640 in the tectonic mod.

commented

If I am not mistaken, we can relatively quickly check if a "section" is completely empty (section being a 16 block high section of the chunk). That means even increasing the height should not have that much of an impact unless there's actually something there to remove.