sky stone tank empty on world reload
jstansel opened this issue ยท 2 comments
Describe the bug
When a sky stone tank is placed in the world and water is stored in it and the world is saved and reloaded the tank is empty.
How to reproduce the bug
- place a sky stone tank
- put water in the tank
- save and quit to title
- load the world again
- the tank is empty
Expected behavior
I expect the water to remain in the tank. I know that the fluid is not kept when the tank is broken but I expected it to remain in a placed tank when the world is saved and reloaded.
Additional details
ATM10 to the sky modpack - version 1.1.2
Single player
Update: I went first to the modpack issues page and was directed to their discord and when I reported the issue there I was told that it was likely not theirs and to report it here.
Which minecraft version are you using?
1.21
On which mod loaders does it happen?
NeoForge
Crash log
I reproduced the issue in a test instance using only AE2 following the same steps as above.
I've found the problem to be a mismatch in SkyStoneBlockEntity. The saveAdditional uses "content" to save the fluid tank content, but loadTag reads it back from "tank". Changing the latter to "content" as well fixes the issue. But you could argue that both should be "tank" as well. The fix is trivial, but which way to fix it is not. Opting for "content" would keep existing saves functional. Any preferences from the devs here?
Git blame suggests it was broken since the 1.20.5 port.