Aquaculture 2

Hello. I just noticed again that aquaculture is appearing on our profiling due to loottables.
Again it is caused by the Industrial Foregoing marine fisher, fishing automatically.

As far as I can tell this profile ran with just 2! Fisher running.
Full Profiling -> https://spark.lucko.me/#lS2O25IRcl

A quick look at the code, this method really needs some optimization/caching. :)

Aquaculture/src/main/java/com/teammetallurgy/aquaculture/loot/BiomePropertiesPredicate.java

Line 63 in bbe7fa5

    
           public static List<Biome> getValidBiomes(List<Biome.Category> includeList, List<Biome.Category> excludeList, List<TemperatureType> temperatureTypes, List<Biome.RainType> rainTypes) { //Can't add biome as a parameter, since this called elsewhere where world is not available

Pretty sure I placed down around twenty last time. That's honestly the reason I am back so quickly... Expecting this to go up really quickly as more people use them.

I've now released AQ2 version 2.1.7, which should have caching working :)
If you could do some profiling for it, that would be great! (Preferably with 2 fishers running, to compare exact numbers to your previous profiling)

Thank you for coming back for an update on this!
I need to rewrite this anyways, as Forge decided to add back in the BiomeDictionary again anyways (Lex had said multiple times that it wouldn't be possible, due to Biome registry changes), so I rewrote it based on the vanilla Biome Category system.
So yea I'll have caching in mind, when I need to rewrite this anyways :)
Isn't it less lag than last time though? Seems it was 9.28% last time and now it's down to 3.46%. I'm not sure how many you were running the previous time though.

Share to