Dupe issue with Vampirism

Question

Dupe issue with Vampirism

maxanier opened this issue 3 years ago · 7 comments

maxanier commented 3 years ago

Hello,

there seems to be an dupe issue with my mod Vampirism and its Bat Mode and the Neptune's bounty block from Aquaculture: TeamLapen/Vampirism#1021

Minecraft 1.16

While the player is in bat mode, I cancel the BlockEvent.EntityPlaceEvent https://github.com/TeamLapen/Vampirism/blob/5fd3c650b577a6d85d0077b6108f8814a0cbaba2/src/main/java/de/teamlapen/vampirism/player/ModPlayerEventHandler.java#L199, which results in Forge removing the placed block again (by restoring the stored block snapshots).
For some reason this results in the following behavior:
When a player in bat mode places a Neptune's bounty block, its content is dropped, but the block is not placed in the world and the item remains in the player's inventory.

I assume this is something I have to fix on my end, but I am a bit lost.
How do I obtain a filled Neptune's bounty item for testing? Is there any way to do so without spending a lot of time fishing?
Also how exactly does the block work and where is the respective itemstack created in code?
I looked through the release-1.16.5 branch, but couldn't find the place where the itemstack is created.

Thank you for your help

maxanier · Answer 1 · 2021-12-05T15:10:15.000Z

Ok, thank you, I will try to build myself a similar item, I can cheat for testing purposes.

GirafiStudios · Answer 2 · 2021-12-05T15:05:48.000Z

The content is applied with the vanilla loot table function "minecraft:set_contents".
Besides that´s, it´s just a vanilla chest with a different texture.
https://github.com/TeamMetallurgy/Aquaculture/blob/master/src/main/resources/data/aquaculture/loot_tables/gameplay/fishing/neptunium.json#L13

GirafiStudios · Answer 3 · 2021-12-05T15:06:50.000Z

1.16.5 link to the loot table:
https://github.com/TeamMetallurgy/Aquaculture/blob/release-1.16.5/src/main/resources/data/aquaculture/loot_tables/gameplay/fishing/neptunium.json#L12

It actually changed slightly in 1.18

GirafiStudios · Answer 4 · 2021-12-05T14:53:57.000Z

Do you mean when placing Neptune´s Bounty for the first time, when having obtained one from fishing?

maxanier · Answer 5 · 2021-12-05T15:01:26.000Z

As far as I understood, yes.(I haven't reproduced it myself, because I did not want to spend hours fishing)

GirafiStudios · Answer 6 · 2021-12-05T15:34:51.000Z

I was able to create a similar item and recreate my issue with a vanilla chest. I did not know vanilla chests were able to store their content in an item stack :) Thank you

No problem, good to hear you figured it out :)

maxanier · Answer 7 · 2021-12-05T15:22:09.000Z

I was able to create a similar item and recreate my issue with a vanilla chest.
I did not know vanilla chests were able to store their content in an item stack :)
Thank you

Share to