Aquaculture 2

Aquaculture 2

95M Downloads

Minnow causes NullPointerException in Industrial Forgegoing Mycelial Culinary Generator

orangelynx opened this issue · 3 comments

commented

Problem: Piping a minnow into Industrial Forgegoing's Mycelial Culinary Generator causes a Server-Side Nullpointer Exception in https://github.com/InnovativeOnlineIndustries/Industrial-Foregoing/blob/259b70ac60714786d1f793124bd66284ac08f1e3/src/main/java/com/buuz135/industrial/block/generator/mycelial/CulinaryGeneratorType.java#L106 .

Could not be reproduced in Singleplayer, where the item is not accepted by the generator at all.

What's clear is that the minnow appears to be tagged as "food", thus bypassing the filter here: https://github.com/InnovativeOnlineIndustries/Industrial-Foregoing/blob/259b70ac60714786d1f793124bd66284ac08f1e3/src/main/java/com/buuz135/industrial/block/generator/mycelial/CulinaryGeneratorType.java#L101

But since it cannot be eaten, it has no healing and saturation values, causing the exception.

Proposed solution: Check proper registration / tagging of the Minnow or add NullPointerException to Industrial Foregoing.

I'm going to crosspost this in https://github.com/TeamMetallurgy/Aquaculture since it's maybe not clear on which side this should be fixed.

Environment: Valhelsia 3.4.9 Modpack, 1.16.5
Industrial Forgegoing v3.2.14.7-16
Aquaculture 2.1.21

commented

Nothing to do with Aquaculture, it´s just a food item with minimal hunger/saturation values. Not doing anything out of the ordinary with it.

commented

Perhaps.. provided you registered/tagged everything properly. After all, why would .getFood() return null if it is food? Will see what the Industrial Forgegoing devs say...