Aquaculture 2

Aquaculture 2

110M Downloads

Mod recipe is unlocked when picking up the first item

HeavySnowExpected opened this issue ยท 2 comments

commented

mod version 2.5.5 Forge 47.4.0 Minecraft 1.20.1

Some of the recipes provided by this mod are unlocked when I pick something up for the first time. Which means, when I just pick up my first log block I will get the recipes of sushi, hooks and many things else.

I feel like this might not be the author's intention? Because, for example, in the mod files the sushi recipe seems to require raw fish fillet or seagrass to unlock, but now I can learn that recipe directly.

commented

After an embarrassingly long amount of time, I have figured out the fix for this. Almost all of the json files in data/aquaculture/advancement/recipes/tools contain a critical typo. A notable exception to this is the neptunium bounty.

Since these files do not correctly specify the list of items to trigger, they ignore their list of items and trigger the recipe unlock advancement on any inventory change.

This is the fix for v1.21.1. I don't know about v1.20.1.

"conditions": {
"items": [
{
//"item: "aquaculture:tackle_box" ->
"items": "aquaculture:tackle_box"
}
]

"conditions": {
"items": [
{
//"tag": "c:rods/wooden" ->
"items": "#c:rods/wooden"
}
]

commented

Although I notice

"conditions": [{"type":"aquaculture:neptunium_armor_enabled","value":true}]

is not picking up on a false enableNeptuniumArmor or enableNeptuniumItems value in the config file. I still unlock those recipes regardless.

An adjacent issue?