Warded Block renderer crashes the game

Question

Warded Block renderer crashes the game

UpcraftLP opened this issue 4 months ago · 0 comments

UpcraftLP commented 4 months ago

Warded blocks, as well as a few other places, multiply the alpha into the color, which in some cases results in a value >1.0, therefore failing to parse back into a Color object.

Stacktrace (click to expand)

java.lang.IllegalArgumentException: blue is not within [0, 255]
--
8 | at com.google.common.base.Preconditions.checkArgument(Preconditions.java:145)
9 | at dev.cammiescorner.arcanuscontinuum.common.util.Color.validateRange(Color.java:288)
10 | at dev.cammiescorner.arcanuscontinuum.common.util.Color.fromRGB(Color.java:53)
11 | at dev.cammiescorner.arcanuscontinuum.common.util.Color.fromFloatsRGB(Color.java:62)
12 | at dev.cammiescorner.arcanuscontinuum.client.ArcanusClient.renderWardedBlock(ArcanusClient.java:374)
13 | at dev.cammiescorner.arcanuscontinuum.client.ArcanusClient.lambda$onInitializeClient$14(ArcanusClient.java:227)
14 | at java.base/java.util.HashMap.forEach(Unknown Source)
15 | at java.base/java.util.Collections$UnmodifiableMap.forEach(Unknown Source)
16 | at dev.cammiescorner.arcanuscontinuum.client.ArcanusClient.lambda$onInitializeClient$15(ArcanusClient.java:225)
17 | at net.fabricmc.fabric.api.client.rendering.v1.WorldRenderEvents.lambda$static$13(WorldRenderEvents.java:146)
18 | at net.minecraft.class_761.handler$ihh000$quilted_fabric_rendering_v1$beforeRenderOutline(class_761.java:16515)
19 | at net.minecraft.class_761.method_22710(class_761.java:1435)
20 | at net.minecraft.class_757.method_3188(class_757.java:1110)
21 | at net.minecraft.class_757.method_3192(class_757.java:880)
22 | at net.minecraft.class_310.method_1523(class_310.java:1219)
23 | at net.minecraft.class_310.method_1514(class_310.java:802)
24 | at net.minecraft.client.main.Main.main(Main.java:250)
25 | at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
26 | at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
27 | at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
28 | at java.base/java.lang.reflect.Method.invoke(Unknown Source)
29 | at org.quiltmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:557)
30 | at org.quiltmc.loader.impl.launch.knot.Knot.launch(Knot.java:84)
31 | at org.quiltmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:28)

Share to