WizardTowerProcessor generates loot during worldgen
Martmists-GH opened this issue · 8 comments
WizardTowerProcessor seems to generate loot at worldgen instead of on request, which can cause a deadlock if majruszsaccessories is installed, as it checks the blockstate of the block when trying to spawn a Swimmer's Guide.
last i checked, chiseled bookshelves dont support loot tables, so short of implementing it myself (or depending on another mod whose whole purpose is doing that), a loot table isnt an option
im not sure why majruszsaccessories is causing a deadlock since structure processors are what you're supposed to do in the situation Arcanus is using it for so
I believe that instead, the NBT should use a LootTable entry for the Chiseled Bookshelves.
I'd recommend checking some datapacks like https://modrinth.com/datapack/dungeons-and-taverns-stronghold-overhaul in that case, since they seem to be able to insert random loot into their structures somehow.
I'm only assuming LootTable on a chiseled bookshelf would work based on the fact that /loot works on them.
From what I've been told, Loot Table generation should not happen during worldgen, but instead use the post-processing API somehow?
I'll have to look into it more when i get home, since im currently at work. its possible Mojang updated the chiseled bookshelf at some point between when i added the structure and now so that they do accept loot tables properly
if so, fuck yea because the structure processor is just one more piece of code that mojang can change and make updating a pain
Even if neither is an option, perhaps it'd be an idea to add an invisible area effect cloud with a specific tag to the structure that will run a function that calls /loot insert on each of the chiseled bookshelves and then removes itself.
The downside is having to run an execute command every tick through a datapack which might not be ideal for performance.
Do not do the jank ass datapack hack workaround that will cause so much more problems than it solves.
Specifically, the ServerLevel is being used which then causes the logic in loot table rolling to query the ServerLevel during worldgen. So when it checks block at spot, ServerLevel tried to grab current chunk, sees it is not finished generating (cause it is generating right now), and then waits for it to finish while within the generating code. Thus the deadlock.
Manually doing the loot table rolling yourself might work if you cannot figure out how to shove the WorldGenRegion into regular loot table rolling. Hardcoding the loot in the processor may also work or read from a custom json file with your items chances and stuff without loot table code.
The proper datapack solution would’ve been make a 2 block tall nbt with jigsaw block and a chiseled bookshelf. And have many all the variants of your bookshelves as all the nbt files. Then shove them into a template pool. And have the main nbt file use jigsaw to pick a random bookshelf nbt to spawn