Forge Particle Registration
jmilthedude opened this issue ยท 2 comments
Hi, I opened a PR which resolves this issue, but it does not resolve the issue how the project managers would prefer. Therefore, I am opening this issue and will reference the PR so that you can take a look and potentially resolve the problem in the future your own way. Simply adding this to track the issue.
The problem:
when registering particles, the implementation as noted in the api does not work. The particles load in Fabric fine, but not in Forge.
The Resolution:
-
The event which registration is called happens too late in the forge lifecycle. The deferred Registry is created in ClientSetup which is too late. Need an earlier point in the Forge Lifecycle.
-
The ParticleFactoryRegistryEvent needs to be used. This is actually implemented but incorrectly in the ParticleProviderRegistry implementation. The event is subscribed but is never called because it is on the wrong bus. Which should be Bus.MOD). See
PR #196 is how I fixed it. You can go off of that if you like.
Forgot to close this when #305 was merged, whoops