Error Internal Exception with Architectury API
IceKarma123 opened this issue · 11 comments
I can't play Singleplay mode due to Achitectury-API 5.8.29
It makes my game connection losthttps://docs.github.com/github/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax
This is my log [Mylogs] (https://pastebin.com/LHzYKZGD)
Error, this is a private paste or is pending moderation.
Oh sorry, here is new linkNew Link
This seems to have only started with newer forge versions, Works fine with .64 however updating to the latest seems to have started this issue
The worst part is I can't get it to happen in my architectury-api workspace 😕
Can you test if it is 41.0.70 that broke it? For example, does 41.0.69 work but 41.0.70 not work?
Ahh, I see
- 41.0.70 Handle modded packets on the network thread (#8703)
* Handle modded packets on the network thread
- On the server we simply need to remove the call to
ensureRunningOnSameThread.
- On the client side, we now handle the packet at the very start of the
call. We make sure we're running from a network thread to prevent
calling the handling code twice.
While this does mean we no longer call .release(), in practice this
doesn't cause any leaks as ClientboundCustomPayloadPacket releases
for us.
* Clarify behaviour a little in the documentation
* Javadoc formatting
* Add a helper method for handling packets on the main thread
Also rename the network thread one. Should make it clearer the expected
behaviour of the two, and make it clearer there's a potentially breaking
change.
* Add back consumer() methods
Also document EventNetworkChannel, to clarify the thread behaviour
there.
* Add since = "1.19" to deprecated annotations ```
I have tried to track down and fix the issue myself however, my brain is having one of those days where you read something and instantly forget it