NeoForge 1.20.2 Holder does not implement Supplier, resulting in FluidStack crash.

Question

NeoForge 1.20.2 Holder does not implement Supplier, resulting in FluidStack crash.

brandon3055 opened this issue 9 months ago · 3 comments

brandon3055 commented 9 months ago

In NeoForge 20.2.59-beta Supplier was removed from net.minecraft.core.Holder

Commit: neoforged/NeoForge@ed1b477

This is the patch that was removed:
https://github.com/neoforged/NeoForge/blob/1ba480f54685088db109e719081d23fb5bc3848e/patches/net/minecraft/core/Holder.java.patch

As a result, FluidStack creation via FluidStack#create(FluidStack, long) crashes with:
java.lang.IncompatibleClassChangeError: Class net.minecraft.core.Holder$Reference does not implement the requested interface java.util.function.Supplier
Full Crash: https://ss.brandon3055.com/ebe85

Jab125 · Answer 1 · 2024-03-17T07:08:54.000Z

wasn't that fixed in #483?

brandon3055 · Answer 2 · 2024-03-17T07:12:30.000Z

wasn't that fixed in #483?

That fix appears to be for 1.20.4, It's still broken in 1.20.2

shedaniel · Answer 3 · 2024-03-19T07:26:37.000Z

Should be closed by #485

Share to