1.20.6 FluidStack.empty() returns null (and FluidStack.EMPTY is null)

Question

1.20.6 FluidStack.empty() returns null (and FluidStack.EMPTY is null)

desht opened this issue 8 months ago · 0 comments

The static init for FluidStack.EMPTY appears to be incorrect:

private static final FluidStack EMPTY = create(Fluids.EMPTY, 0);

Following the create() method call chain leads to this method:

public static FluidStack create(Fluid fluid, long amount, DataComponentPatch patch) {
    if (fluid == Fluids.EMPTY || amount <= 0) return empty();
    return create(() -> fluid, amount, patch);
}

Since the amount is 0, empty() is called, which returns EMPTY, which at this point is still null.

Share to