Armor Statues [Forge & Fabric]

Armor Statues [Forge & Fabric]

1M Downloads

[Bug]: Packet issues kicking me off server

TaeoG opened this issue · 6 comments

commented

Mod Loader (Required)

Forge

Minecraft Version (Required)

1.19.2

Mod Version (Required)

4.0.4

Notes (Required)

Installed Mods:
Armor Statues 4.0.4
Straw Statues 4.0.10
JEI 11.6.0.1013
Puzzles Lib 4.3.12
Forge 43.2.6

Issue:
If I try to enable the arms on the statue, or move it with the gui, or press some of the other checkboxes, the server will kick me off, with an error like:
Internal Exception: io.netty.handler.codec.EncoderException: java.io.EOFException: fieldSize is too long! Length is 56320, but maximum is 21
or
Internal Exception: java.lang.IndexOutOfBoundsException: index 4, length: 11839 (expected: range(0,25))
or
Internal Exception: java.lang.IndexOutOfBoundsException: readerIndex(17) + length(8) exceeds writerIndex(21): PooledUnsafeDirectByteBuf(ridx:17, widx:21, cap:21)

No seemingly related errors appear in the log, these errors just appear on the client screen with the button to return to server selection.

I've tried using Connectivity and/or XL Packets to see if they resolve the issue, but they don't seem to. The Straw Statue causes similar problems.

Sometimes, rather than simply booting me off the server, it will crash the client.

latest.log (Optional)

https://mclo.gs/FpYRC0i

commented

this also happens to me

commented

This is likely caused by Straw Statues and Armor Statues sharing a network handler, I assume the packet order is inconsistent between client and server from both mods registering packets in different orders on either side.

The latest version of Armor Statues includes a simple workaround for this by changing the internal id used for the network handler, so the network handler is no longer shared between both mods.

This will properly be addressed in the 1.20 port where the whole statues api will be moved to a separate project, so there is no need anymore to keep this common code in both mods separately.

commented

I am also having this same issue. I have this included in my modpack running 1.20.1, and forge version 47.1.46. The mod is installed on the client and on my server. When changing any of the checkboxes or trying to name the stand it will kick me off the server with one of the above errors. Also, when logging out of the server and back in it will not save the positioning of the armor stand. However, I am able to add items from the equipment tab and they will stay on the stand.

commented

I've got the same error on 1.20.1 in a modpack the only mod that changes the armor stands is this one and it still kicks me of the server by saying: Internal Exception: io.netty.handler.codec.EncoderException: java.io.EOFException: fieldSize is too long! Length is 24944, but maximum is 11.
On the server's side it's the same error: [16:37:58] [Server thread/INFO] [minecraft/ServerGamePacketListenerImpl]: TheCuteFireBoy lost connection: Internal Exception: io.netty.handler.codec.EncoderException: java.io.EOFException: fieldSize is too long! Length is 24944, but maximum is 11

Do i need to do something or is it from the mod? I use forge 47.1.0 if it helps. I would've put the mod list here but... it's long and idk how to get the mod list without me typing it manually.

EDIT: Also i do not know if it's from this mod or not, but the armor stand that spawn in villages with armor on them duplicate like 3 or 4 times. (Idk if it's this mod, but this is the only one that interacts with armor stands that i have installed.

commented

This is likely caused by Straw Statues and Armor Statues sharing a network handler, I assume the packet order is inconsistent between client and server from both mods registering packets in different orders on either side.

The latest version of Armor Statues includes a simple workaround for this by changing the internal id used for the network handler, so the network handler is no longer shared between both mods.

This will properly be addressed in the 1.20 port where the whole statues api will be moved to a separate project, so there is no need anymore to keep this common code in both mods separately.

1.20.1, this still happens for me.

commented

Fixed in v8.0.4.