[1.16.5] 16.5.0 - Non Effect Providing Armors Throw a null effect when invoked, caused by a null effect list.

Question

[1.16.5] 16.5.0 - Non Effect Providing Armors Throw a null effect when invoked, caused by a null effect list.

TheDarkPreacher opened this issue 3 years ago · 13 comments

TheDarkPreacher commented 3 years ago

Affected Versions (Do not use "latest")::

Minecraft: 1.16.5
ArmorPlus: 16.5.0
TheDragonLib: 1.1.0
GeckoLib: 3.0.49
Forge: 36.2.8
(Optional) Just Enough Items (JEI): 7.7.1.129

Affected Side (Client or Server):

[X ] Client
[X ] Server

Describe the issue: When updating from Smashing Mods Together version 1.0.2 to 1.0.3-hotfix on server, if a player is wearing ArmorPlus armor when connecting to server, there is a Ticking Player crash, which causes the player to never actually connect with their client.

(Optional) Additional notes: Smashing Mods Together version 1.0.2 uses ArmorPlus version 16.4.1, TheDragonLib v. 1.1.0, GeckoLib v. 3.0.49, and Forge 36.2.8. Issue also reported to Smashing Mods Together pack dev SmashingMods/SMT-Issues#7

TheDarkPreacher · Answer 1 · 2021-11-08T10:03:55.000Z

Update: Latest.log from the crash

https://gist.github.com/TheDarkPreacher/9d21c1aafdddd6ea5e63909d1b8511f3

sokratis12GR · Answer 2 · 2021-11-08T16:30:13.000Z

Hey there, thanks for your report, but I'm afraid that log report doesn't contain any information about the crash, and nothing related to ArmorPlus.

TheDarkPreacher · Answer 3 · 2021-11-08T18:29:33.000Z

Sorry, it was super late, had a ton of logs to go through, snagged the wrong one. This is the only crash log I can actually find on the server, since the one it says it generates in the log can't be found. https://gist.github.com/TheDarkPreacher/885c3a370bc967014066525ea073ff41

sokratis12GR · Answer 4 · 2021-11-08T18:42:03.000Z

Thanks for that, which armor was being equipped/is affected?

TheDarkPreacher · Answer 5 · 2021-11-08T18:44:13.000Z

The enhanced diamond armor. I made a partial set (ran out of glowstone before I could make boots) and if I'm wearing any of it, Ticking Player crash in 16.5.0.

…

On Mon, Nov 8, 2021 at 12:42 PM Sokratis Fotkatzikis < ***@***.***> wrote: Thanks for that, which armor was being equipped/is affected? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#256 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADS4PCR7Y3NNYSUXJKJVZLLULAKYLANCNFSM5HRL3R3A> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

sokratis12GR · Answer 6 · 2021-11-08T18:49:51.000Z

Alrighty thanks, that shouldn't be happening considering the armor has no effects, does that happen with other armors (excluding enhanced)?

TheDarkPreacher · Answer 7 · 2021-11-08T18:57:42.000Z

I have no idea, honestly, I hadn't had a chance to make any other sets yet.

…

On Mon, Nov 8, 2021 at 12:50 PM Sokratis Fotkatzikis < ***@***.***> wrote: Alrighty thanks, that shouldn't be happening considering the armor has no effects, does that happen with other armors (excluding enhanced)? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#256 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADS4PCXGA7LX534TGGCVLALULALVVANCNFSM5HRL3R3A> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

TheDarkPreacher · Answer 8 · 2021-11-08T20:24:29.000Z

Did some testing on a fresh server, here is the list of effected armor sets. Enhanced Iron Enhanced Gold Enhanced Diamond Enhanced Netherite Manyullyn Pig Iron Cobalt Same crash, every time, like clockwork. On Mon, Nov 8, 2021 at 12:57 PM The DarkPreacher ***@***.***> wrote:

…

I have no idea, honestly, I hadn't had a chance to make any other sets yet. On Mon, Nov 8, 2021 at 12:50 PM Sokratis Fotkatzikis < ***@***.***> wrote: > Alrighty thanks, that shouldn't be happening considering the armor has no > effects, does that happen with other armors (excluding enhanced)? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#256 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ADS4PCXGA7LX534TGGCVLALULALVVANCNFSM5HRL3R3A> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > >

sokratis12GR · Answer 9 · 2021-11-08T20:41:01.000Z

Alrighty thanks, seems all non-effect providing gear were affected, will be fixed in the next patch.

TheDarkPreacher · Answer 10 · 2021-11-08T20:47:37.000Z

Awesome, thanks!

…

On Mon, Nov 8, 2021 at 2:41 PM Sokratis Fotkatzikis < ***@***.***> wrote: Alrighty thanks, seems all non-effect providing gear were affected, will be fixed in the next patch. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#256 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADS4PCUQVFJBVLSOREXRQKDULAYWRANCNFSM5HRL3R3A> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

Dark-Arcana · Answer 11 · 2021-11-08T20:54:43.000Z

Thanks for the update on the issue. When your mod updates, I will update it in my pack.

sokratis12GR · Answer 12 · 2021-11-10T08:16:46.000Z

Hey there, thanks for waiting.
ArmorPlus 1.16.5-16.5.1 should fix this issue.
Note: Please delete armorplus related configuration files after updating.

Dark-Arcana · Answer 13 · 2021-11-10T22:20:33.000Z

Thanks! I'm adding this to my next update. We'll report back if there's any other issues.

Share to