Armourer's Workshop

Armourer's Workshop

2M Downloads

[BUG] RT shader not working

ShenxPresent opened this issue · 8 comments

commented

Describe the bug
shadow incorrect when use PTGI in 1.16.5

Expected behavior

Screenshots
image

Debug crash log
no crash

Additional context
It seems that someone can ust PTGI with correct shadows, but no details. https://tieba.baidu.com/p/6900586120

commented

the link aw is 1.12

commented

the link aw is 1.12

another finding is that it used PTGI e7, but there's still an issue that many shaders are not work correctly.

commented

链接 aw 是 1.12

Finding that is the incorrect normal culculate, I am trying to fix it in shader pack

commented

It seems like that the bug is mainly caused by the incorrect tbn culculation, which means there's maybe some issue on the texcoord.

commented

Fine... Now here's a solution, it seems like that the tbn could make the viewnormal out of range(-1,1), which I thought could be fixed by the mod side, if this could be fixed it seem like better than waiting for all shader add clamp function during culculating normal in view space.

commented

i need more details, possible in qq or discord to discuss?

commented

i need more details, possible in qq or discord to discuss?

sure, I have send my request to join your qq group.

commented

fixed in next release