ARRP

ARRP

3M Downloads

JLang.entity() uses wrong translation key type

Fourmisain opened this issue ยท 1 comments

commented

ARRP's JLang.entity() produces translation keys of the form "entity_type.<namespace>.<path>" when it should be "entity.<namespace>.<path>".

The latter can be seen in the Minecraft en_us.json file, e.g. "entity.minecraft.polar_bear": "Polar Bear" and EntityType.getTranslationKey() also uses "entity".

Not a big deal when there's JLang.entityRespect(), just letting you know.
Should be easily fixed by changing these 2 strings here:

public JLang entity(EntityType<?> type, String name) {
return this.object(Registry.ENTITY_TYPE, "entity_type", type, name);

public JLang entity(Identifier id, String name) {
return this.object("entity_type", id, name);

commented

This was done to avoid breaking backwards compatibility if I remember correctly