Ars Nouveau

Ars Nouveau

70M Downloads

remove setMaxSource about ISourceCap

Frostbite-time opened this issue ยท 2 comments

commented

The maximum capacity of a container should be determined by the container itself. It's inappropriate to provide this method in the ISourceCap class, which is used for capability registration. Since this method hasn't been used yet, removing it should be quite straightforward.

commented

Regarding the addSource and removeSource methods of ISourceTile, their comments indicate that they return the increment or decrement, but in your specific implementation, they actually return the total amount after the addition or removal. I'd like to know whether this is an issue with the comments or if you plan to make changes in the future?

commented

Regarding the addSource and removeSource methods of ISourceTile, their comments indicate that they return the increment or decrement, but in your specific implementation, they actually return the total amount after the addition or removal. I'd like to know whether this is an issue with the comments or if you plan to make changes in the future?

Sorry, that was my mistake. Jumping back and forth between the code for versions 1.20.1 and 1.21.1 confused me.