[BUG] Duping with Sribe's Table and Tinker's Contstructs' Crafting Station
dumbdemon opened this issue ยท 4 comments
Versions
Ars Nouveau - 2.7.8
Tinker's Construct - 3.5.1.31
Curios API (Forge) - 5.0.7.1
GeckoLib - 3.0.38
Mantle - 1.9.27
Patchouli - 71.1
What happens:
There's a duplication glitch with the interaction between the crafting station and Ars Nouveau's Scribe's Table when placed next to each other in 1.18.2. It showed up in All the Mods 7 and I tried it again with only just the two mods and its dependencies. When placed next to each other the crafting station detects the scribe's table inventory. When you place a item with at least two ore more into that inventory and try to take it out with out shift-clicking it creates a new stack and lessens what's in the detected inventory by one.
Duplicate issue was created on Tinkers Construct git: SlimeKnights/TinkersConstruct#4994
For the record, all we do s access the item handler capability and use the methods from IItemHandlerModifiable. If your item handler is not going to behave properly when used in a UI, there is no reason to implement IItemHandlerModifiable. We also have a tag to blacklist it.
This bug looks to be caused by this very suspect code here: https://github.com/baileyholl/Ars-Nouveau/blob/1.19.x/src/main/java/com/hollingsworth/arsnouveau/common/block/tile/ScribesTile.java#L341-L346. I see no way that making a copy of the stack and shrinking by one will not cause dupes. A copy with stack size 1 (e.g. a stack.split) would work fine.
