Ars Nouveau

Ars Nouveau

49M Downloads

Wixies are no longer able to craft custom potions

MuteTiefling opened this issue · 2 comments

commented

ars_nouveau-1.19.2-3.10.1
morejs-forge-1.19.2-0.0.7

I've been useing MoreJS to add different crafting recipes for potions. Previously, I was able to have a wixie craft these without issue.

Now, however, it seems she doesn't recognize the items.

For example, she'll craft potions of leaping with the Rabbit's Foot and Wilden Wing, but not with the Crescent Fruit shown below.
image

commented

Hey, MoreJS dev here.

From what I see it looks like you create own recipe wrappers when calling addMix. In MoreJS I directly add the mix to the list instead of using addMix. The reason is to let users define custom ingredients with nbt checks etc.

MoreJSEvents.registerPotionBrewing((event) => {
    const ing = Ingredient.customNBT(/.*/, (nbt) => {
        return nbt.contains("Damage") && nbt.getInt("Damage") < 10;
    });
    event.addPotionBrewing(ing, "minecraft:fire_resistance", "minecraft:strength");
});

https://i.imgur.com/Y31eq6F.mp4

Currently I have two solution in mind.

  1. Ars could probably mix into the Mix constructor.
  2. I use addMix(Potion potion, Item item, Potion potion2) instead of creating my own Mix object. But this will remove the ability to use custom ingredients, because of the way Mojang designed the method.
commented

No worries, just some old cache code out of date. I think forge used to call addMix with their brewing registry, but I guess that changed or I imagined it.