ArtemisLib

ArtemisLib

Mods
2M Downloads

[1.13.2] Capability provider throws NPE

TheIllusiveC4 opened this issue ยท 2 comments

commented

Versions:

  • ArtemisLib: 1.13.2-1.0.3
  • Forge: 1.13.2-25.0.100

Specifically, this method:

ArtemisLib/src/main/java/com/artemis/artemislib/capabilities/sizeCap/SizeCapPro.java

Line 34 in 8cfba97

public <T> LazyOptional<T> getCapability(Capability<T> capability, EnumFacing facing)

This method is nonnull, so it should return an empty LazyOptional instead. Otherwise, other mods that try to access their capabilities from instances of EntityLivingBase will get an NPE from this mod.

Something to note is that ArtemisLib won't show up in the stacktrace of the crash at all so it could cause erroneous bug reports for other developers. Like so: TheIllusiveC4/Curios#4

commented

What exactly are your suggestions for fixing this? Our capabilities guy, XzeroAir, hasn't been able to fix the crash so far.

commented

My suggestion is just to return LazyOptional.empty() instead of null to comply with the nonnull method, that's all. I'm no expert at capabilities myself, especially with the new Forge changes, so I don't have much insight after that. I see that there has been a commit to try and resolve the issue that's more recent than the comment above so I don't know if you guys are still having a problem, but I don't see any issues with the latest commit personally.