Artisan Worktables 1.12

Artisan Worktables 1.12

3M Downloads

Tables not working with designer's table

Remyrios opened this issue ยท 21 comments

commented

Issue Description

Tables won't work if you connect designer's table to them. After you break designer's table the main table is still unusable until you place other table in the place of the broken designer's table.

What Happens

Designer's table breaks interaction with tables attached to it.

What You Expect to Happen

Other tables should work fine with additional content added from designer's table.

Script

No scripts involved

Crash Log

No crash log involved

Affected Versions

Do not use latest; please supply accurate version numbers.

  • Minecraft: 1.12.2
  • Forge: 14.23.2.2654
  • CraftTweaker: 4.1.6
  • Artisan Worktables: 1.19.0-SNAPSHOT.2
  • Athenaeum: 1.14.0
commented

Is there anything in your log file related to this mod?

commented

And, to be clear, by "doesn't work", you mean that you are still experiencing the problem?

commented

Yeah, I found something related to designer's table, here is the log: https://hastebin.com/usiselemic.md

commented

Yes it's the same issue

commented

Ok, great! Something I can work with! :)

This is in single player, correct?

commented

Also if that helps my java version is 1.8.0_131

commented

This is a weird one, because AbstractMethodError is:

Thrown when an application tries to call an abstract method. Normally, this error is caught by the compiler; this error can only occur at run time if the definition of some class has incompatibly changed since the currently executing method was last compiled.

This could indicate that there is something wrong with the version on Curse.

commented

It also happened on snapshot 1 too - another info

commented

And yes it is SP

commented

I was able to reproduce this issue by doing the following:

  1. Setup new instance in Twitch launcher using Forge 2654
  2. Download Artisan Worktables 1.19.0-SNAPSHOT.2
  3. Download Athenaeum 1.14.0
  4. Follow the steps in #108 (comment)

This instance runs Java 1.8.0_25.

The mod is built against Java 1.8.0_144.

Next, I'm going to attempt the same test with this Twitch instance, but point it to use my installed JRE version 1.8.0_144.

commented

The issue still occurs with 1.8.0_144 running it with the Twitch instance and the publicly available jars.

commented

Ok, I finally understand why this is happening.

I have an interface ITileEntityDesigner which is implemented by all my designer table tile entities. These TE's also extend the class TileEntity, obviously. The method boolean ITileEntityDesigner#isInvalid() is then satisfied by the super class method boolean TileEntity#isInvalid().

The method that satisfies the abstract requirement of the interface is, however, re-obfuscated at compile time because the method is part of the obfuscated MC codebase. This means that when the method is called at runtime, there is no longer an implementation of the method to back the abstract signature, and the AbstractMethodError is thrown.

It makes sense now!

Thanks for bringing this to my attention. It should be fixed up in the next alpha snapshot.

commented

I can't reproduce this.

Please elaborate on:

Tables won't work if you connect designer's table to them.

Please provide detailed steps to reproduce this issue, thanks.

commented

https://streamable.com/ojvhc Sorry for the lag just my pc isn't the best

commented

From the video, it looks like these are the steps:

  1. Place Blacksmith's Table (BT)
  2. Add bucket of water to BT
  3. Verify 1000mb of water in BT
  4. Place Designer's Table (DT) adjacent to BT
  5. Attempt to add bucket of water to BT
  6. Observe water is not added
  7. Attempt to open the BT gui
  8. Observe gui does not open

I followed the same steps that I observed in your video and I still can't reproduce the issue.

Can you reproduce the issue using the same versions, with no other mods present? It may be a mod conflict issue.

I was using Forge 2635 and I'm updating to the version you listed, 2654. I'll see if I can reproduce this with that version.

commented

I've updated to Forge 2654 and no luck reproducing the issue.

https://streamable.com/bkwv3

At this point, my best guess is that the issue is a mod interaction issue.

commented

That water bucket was there by mistake :P I will check without any other mods

commented

Ok, thank you. Please let me know what you discover. :)

commented

It doesn't work with just Artisan Wokrtables, Athenaeum and CraftTweaker

commented

Fixed in 1.12.2-1.19.0-SNAPSHOT.3