AstikorCarts [Horse Carts]

Versions
Minecraft Version: 1.18.2
Minecraft Forge Version: 40.2.0
Mod Version: 1.1.2

Log files
Please append the log, debug-log and if available the crash-log files.

latest.log
2023-02-06-7.log.gz
crash-2023-02-06_14.07.02-client.txt
crash-2023-02-06_14.11.17-client.txt
crash-2023-02-06_13.32.04-client.txt
crash-2023-02-06_14.05.21-fml.txt
Not all may be relevant but I included them to see the full magnitude.
Modpack of 190 mods. There MIGHT be EVEN MORE culprits among these as I am still to test 57 mods that potentially can be innocent, though. Please do get in touch with the other authors linked below if you are not a cause but a bystander.

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behaviour:

Add following mods: SakuraBlossomGrotto (+ Terra Blender), this also happens with Tumbleweed, add Astikor's Carts. The game will crash when trying to create the pig model due to a NullPointerReferenceExeption.
Disable either Astikor's Carts or both SakuraBlossomGrotto and Tumbleweed. If either AC, MID + SBG or T are together, the game crashes.

Expected behaviour
No crash, lol.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context

Other crash reports on the other mods
Dekunutter/CherryBlossomGrotto#36
konwboj/Tumbleweed#33 (no response yet)
GeheimagentNr1/ManyIdeasDoors#4
#88

Dekunutter found a reson for the crash. It has to do with the way items are registered. Please read the thread and see if you can also implement a fix on your side. Dekunutter/CherryBlossomGrotto#36 In hope you find a way, there is an explanation on what can be done, I am just a noob you might understand it better.

Tumbleweeds is currently incompatible to ManyIdeasDoors + AstikorCarts combined. Sakurablossomgrotto was incompatible but is now fixed. I hope you can be so kind to apply this to your mod as well so I can activate all mods. 🙏

The issue stems from

astikor-carts/src/main/java/de/mennomax/astikorcarts/CommonInitializer.java

Line 42 in 43facc6

.execute(() -> ObjectHolderRegistry.removeHandler(this));

I don't know if it's a concurrent modification issue (the line removes items during iteration) or something else (spent way too much time debugging it already) but it removes the wrong handler.

I spent some time to get in contact with people and Verph apparently found a fix in their TFC fork, also including the line konwboj mentioned.
I could fork the original mod (I asked issork if that's okay) and apply Verph's changes.
You can take a look at the fork here: https://github.com/xDonnervogelx/astikor-carts-bugfix/tree/1.18.2_bugfix_attempt_01

For users looking for a short-term solution, you can try my fork, I published it on CF yesterday. There might be issues with the config as I have not enough knowledge to understand what actually was causing the issue, what was changed, and how it impacts the rest of the mod. I hope this helps mend the issue long-term. If not, at least I can apply changes, if given enough guidance. or just fork from me, whatever you see fit. Just trying to help, either way.
Mod link:
https://www.curseforge.com/minecraft/mc-mods/astikorcarts-horse-carts-pigcrash-fix-fork

Thanks for the fix, this has been giving me a headache all day

You're welcome.

Also, if anybody is up for trying to help me getting the config to work on my fork, feel free to contact me. I can use any help I can get. I'm in contact with some people, but any point towards a solution, or an idea is worth a try. The sooner we get it fixed as a "community" the sooner we can also lay back and enjoy the functionality again :)
I checked myself recently and the config is really unavailable, so if that's a bother for anybody - maybe you got an idea towards the solution. I'll happily listen. Keeping this open until it's fixed on the original mod anyways, but it's also an open issue on my side.

Share to