Astral Sorcery

Astral Sorcery

63M Downloads

Mod interaction bug AE2 and Ceramics

Sunekaer opened this issue · 7 comments

commented

FTB Issue tracker: FTBTeam/FTB-Builders-Paradise#31

Hi,

Clay Buckets from Ceramics with fluid are stuck in ME Drive, Clay Buckets without fluid or with vanilla in can be taken out of the ME Drive without problems.
Removed/disabling Astral Sorcery fixes the issue

Issue can be recreated with only the mods below
image

commented

Most likely due to capability discussed in #762. Address with AE2 or Ceramics.

commented

Ceramics can't do anything about this, it's AS there is doing something so these items are stuck in the AE2 system.

commented

You clearly didnt read the linked ticket. AS does nothing to AE, except add an nbt tag to non-stackable items.

commented

Why does it add any data to non-stackable items? That seems like a bad idea 🤔

commented

Because the alternative is maintaining an exhaustive list of every equippable item that exists in modded. There is no other way to indicate whether an item is an equippable for adding the capability to it, other than adding the capability to every non stacking item. Or maintaining thousands of lines of tracking for items

commented

No, I'm pretty sure the alternative is checking Item#isValidArmor(ItemStack, EntityEquipmentSlot, Entity) or Item#getEquipmentSlot(ItemStack) != null and only adding cap to those items. After reading more source code, I see that it's not exclusive to armor only, and also adds it to tools. Could also not add cap at all and only add NBT data when necessary/its actually changed/added by AS mod.

commented

Except that doesn't prevent people from adding or duplicating insane numbers of enchantments, which can then be stripped off and reapplied, using one of the many methods to pull items out of inventory without the player de-equipping them creating a loop. That is why the capability is there.

Again, this is something not being handled properly with the NBT tag written to the item when it's being stored. Assuming that there is not an issue with how ceramics handles its bucket code, this needs to go to AE to have them address it on their side.