[1.14.4-indev] Unreleased AS bugs compilation
yavincl opened this issue · 8 comments
Bug #1 of Unreleased AS bugs compilation
[removed, not a bug]
Tickets shouldn't be filed for unreleased versions. Some things don't work in the git code that work in the closed dev, or aren't converted yet.
Yikes. I still feel that any feedback I am able to give has a net benefit to AS's development, so I will keep this issue around for any bugs I find on the git code, instead of putting them on individual issues (to prevent spam!)
You can keep this closed if you want, just do remember to keep an eye on it 👀
If anyone else is interested on helping with the development of the future release of AS 1.14.4, I've fabricated a little script that spits out usable mod jars to put in the game, and makes clean changes to the original repository to facilitate making pull requests:
https://github.com/yagoplx/HellfireBuilder
HellfireBuilder does not contain any proprietary code and is compliant with the Astral Sorcery License.
Removed the first "bug report" because it is not a bug- just user error due to lack of knowing.
Found out that generating the mod's datapack and resourcepack is done by ./gradlew runData.
Yet, running ./gradlew build afterwards does not package the generated vanilla resources into the jar. How is this done in a development setup? Can't really figure it out by myself... @HellFirePvP
Neither does ./gradlew runClient have any of these resources loaded.
I've worked around this by having HellfireBuilder make a datapack that I put in the worlds datapack folder, and making a resource pack that goes in the instance resourcepack folder. This makes AS 1.14.4 work as intended- with all features showcased in the devlog videos.
This was quite fun, but I guess I got what I wanted in the first place.
Now we get developing!
I'm mostly going to use this to make memes and the likes, as my knowledge of Java is abysmal and I've realized that I cannot be of much help, further than this.
Suggestion: Review the Attunement Altar's code.
The Attunement Altar, once built, and tuned to a constellation, will not remember that it is tuned to that constellation if you leave the world at day, return, and set the time to midnight. (happens too if the transition from day->night is natural)
This is anomalous because the constellation is still on the sky.
Suggestion: Review the Illumination Wand's code.
Some tile entities can be illuminated and this leads to weird behaviour.
Some things should not be affected by the wand.
Click me to see this issue in action
Edit: reuploaded to youtube because gfycat clipped the footage.
[Unfinished, not a bug, addressed by Hellfire already]
Upon having starlight shot into it, the functioning Ritual Pedestal will instantly render all the "leaking" starlight beams. They are purely visual and don't do anything.
Amongst other oddities.
Bug: Changing resource packs permanently screws up the skybox
Yes, this is on the unmodified debug source, assets are being packaged into the jar as HF told me to do.