Enchantment Hooks causing TPS issues - 1.13.12 - All the Mods 6
Column01 opened this issue ยท 24 comments
When running the ATM6 modpack (version 1.7.2), astral sorcery seems to be lagging the server with enchantment hooks. This was apparently fixed in version 1.13.11
(see #1751) but ATM6 is currently running version 1.13.12
and this is still present.
You can see the profile here (tombstone also lags with the shadow step enchant, but Astral has been the biggest offender.)
Mod Version: 1.13.12
Forge version: 36.1.65
97.2 MSPT minimum in the last minute but only 5% CPU load? I doubt you're using a 20+ core system, so something must be limiting the server's CPU usage.
1.3 seconds was eaten by astral, and the 1.3 under tombstone was again majority astral sorcery enchantment hooks
How. long. was. the. test. run. for?
Because, again, looking at the entire server thread output I screenshot above, astral, like most of those mods listed during the profile, had a neglible impact on overall server hit. The sources list doesn't even list non-modded code. Listening for event triggers is EXACTLY what event listeners are for.
1.3 seconds is irrelevant unless the entire thing was captured for a matter of seconds. In which case, gather one that runs for several minutes instead and upload it. Every time someone posts one of these since that issue was fixed, it's been shown to be irrelevant.
Oh, looking at the profile again, the tombstone lag has the majority of it coming from astral's enchantment lookups
Run it for five minutes. Post it again. Get data that's relevant over a timespan that matters, while the server is actually doing something.
And, again, what's the overall server CPU load while this is going on? Is anyone playing? Is it just running blank? Context matters.
CPU load is negligible (5%), but TPS is shattered. Memory usage is also low, 33% of allocated and there are 5 playters currently playing. The profiler used is called Spark (rtfm), and you don't need to run a 5 minute profile to get a good idea of what's causing lag. The MS counters (and the corresponding percent value) next to the sources show how much of the total tick time was eaten by that given source, and out of 15 seconds of tick time, astral ate 1.3 seconds of it doing its enchantment lookups.
I will however oblige you and run a 5 minute profile and post it when it completes
If TPS is low but your CPU load on the core running MC is also low, that's not Astral.
New 5 minute long profile: https://spark.lucko.me/Vi6268vbm3
Alright, but if that were the case, why does killing all zombies, fish etc. not improve TPS at all? This entire time it's been lagging I've been purging entities and it doesn't improve TPS at all. I assumed the enchants were held by a mob since my players all swear they aren't using any enchants from astral or the tombstone mod (shadowstep)
the event bus being monitored by both mods is irrelevant at the end of the day, honestly. I wouldn't even bother reporting this to Tombstone either.
And I don't know why purging doesn't change things, because it doesn't change that's what's eating server threading.
I suspect that CPU load is aggregate across all cores, and the core running the server instance is probably pegged out.
Then that makes it even worse.
Something is limiting the MC server thread. It's not Astral that is causing problems.
What could possibly be limiting the MC server thread? We had this issue on Java 8 and recently updated to Java 11 and still have this problem. I can send you the JVM args if you want if you think that would help
New 5 minute profile on peaceful: https://spark.lucko.me/x6l65ooep6
We gained ~2 tps from being on peaceful
Astral is contributing to the lag, but after some extensive goofing it seems to be mobs are spawning with enchantments ALOT and causing lag. Does anyone have recommendations for reducing mob spawns (I.E. setting spawn limits?)