Infused crystal sword does not credit the player for celestial damage
unascribed opened this issue ยท 2 comments
This was reported to me as a GlassHearts bug, wherein Sapping does not proc when a mob is killed by the secondary damage from the infused crystal sword.
The linked code uses a static shared DamageSource for all celestial damage, instead of creating EntityDamageSources that credit the player. (I don't have a workspace open right now and don't have the exact class name.)
I would guess the player not being credited is unintentional, but I could be wrong.
This is a rather tricky problem since from my design point it would not be the player as direct source of the damage. So.. yea. It's not the player doing the damage by design, however i can see this being potentially problematic for certain features. i'll see to it...