Astral Sorcery

Astral Sorcery

63M Downloads

Please use a whitelist for WorldProvider hijacking

thiakil opened this issue ยท 3 comments

commented

https://github.com/HellFirePvP/AstralSorcery/blob/master/src/main/java/hellfirepvp/astralsorcery/common/event/listener/EventHandlerIO.java#L49

You appear to be hijacking the provider unless something is listed in weakSkyRenders, but without a check for whether that dimension is even in the whitelist of skySupportedDimensions

This is creating issues with any mod using dynamic dimensions that checks for its own world provider; one would have to add every dimension number (existing or not) to that list to get around it.

commented

The next update removes solar eclipses darkening the world anyway, so this is from that point onwards kinda redundant anyway. - Not that you could've known that. :P

commented

fair enough

commented

815ab70 closed this - idk why github didn't insert the commit link here.