Please use a whitelist for WorldProvider hijacking
thiakil opened this issue ยท 3 comments
You appear to be hijacking the provider unless something is listed in weakSkyRenders
, but without a check for whether that dimension is even in the whitelist of skySupportedDimensions
This is creating issues with any mod using dynamic dimensions that checks for its own world provider; one would have to add every dimension number (existing or not) to that list to get around it.
The next update removes solar eclipses darkening the world anyway, so this is from that point onwards kinda redundant anyway. - Not that you could've known that. :P
815ab70 closed this - idk why github didn't insert the commit link here.