Astral Sorcery

Astral Sorcery

Mods
63M Downloads

Crash when using Tree Beacon with Integrated Dynamics' Menril Saplings

Darksilver78 opened this issue ยท 8 comments

commented

Server / Client will crash when using Menril Saplings in the Tree Beacon.

Modpack: Horizons III v1.2.0

How to replicate: Place Tree Beacon and 1 Menril Sapling. Bone meal the sapling until it's grown and becomes the 'ghost' Menril Tree. Place second Menril Sapling, when it grows (bonemeal or not) server/client will crash.

commented

Considering the weirdness I've seen out of those trees with other harvesting methods, somewhat shocked the tree beacon processed it into a ghost tree at all.

commented

That is indeed correct ^

commented

My bad, good catch!

commented

Just nothing gets mixed up: Menril Spalings are from Integrated Dynamics and not Industrial Foregoing

commented

Not on my end. Handing it over.

commented

AstralSorcery/src/main/java/hellfirepvp/astralsorcery/common/tile/TileTreeBeacon.java

Line 149 in a58d238

} while (TreeCaptureHelper.oneTimeCatches.contains(possibleSapling) || tries > 0);

AstralSorcery/src/main/java/hellfirepvp/astralsorcery/common/tile/TileTreeBeacon.java

Line 163 in a58d238

} while (TreeCaptureHelper.oneTimeCatches.contains(possibleSapling) || ticksToExecute > 0);

Are those ||s supposed to be &&s? I get stuck in an infinite loop on the first one.

commented

I found no less than 3 bugs that all conspire to cause this. They should all be fixed, but fixing any one of them will resolve the issue.