Astral Sorcery

Astral Sorcery

63M Downloads

[Suggestion/Compatibility] Add a list for ores to be checked by the ore discovery feature of the infused pickaxe

Lathanael opened this issue ยท 2 comments

commented

I am currently working on a 1.12 mod pack with a heavily altered ore generation due to CustomOreGeneration and Harder Ores. Thus every normal ore block gets replaced/is not generated and only the Harder Ores ones can be found underground. This however results in a problem as these ores do not extend BlockOre but rather the normal Minecraft Block class (Harder Ores source for ore blocks). Your OreDiscoverer (AS source - OreDiscoverer.java - line 64) relies solely on identifying ores by their extension of the BlockOre class.

This could be "fixed" by adding another list like the ones for the mineralis ritual or ritual shrine (This one here if i am not mistaken). This list would get checked in addition to the BlockOre check in the OreDiscoverer class. Thus a user can add other blocks or ores which would be picked up by the infused pickaxe without the need for hard coding any compat for other mods on your end. Of course this is only a suggestion and a hint on how such a thing could be implemented (or rather how i would implement it :-)). By no means do i want to tell you how it should be done if you decide to implement this feature.

commented

Aehm excuse me?! If you close an issue please also include an explanation why! Either referencing a commit or a simple "won't fix/implement" is enough imo. But closing with no feedback is not ok in my book!

commented

There's a fucking master ticket all these were compiled under to make navigating the actual issues easier, I just didnt want to link 28 other tickets to it.

Fix your tone for next time.