Astral Sorcery

Astral Sorcery

Mods
63M Downloads

Cross-Mod interaction due to enchantment level ASM patch

dashkal opened this issue ยท 1 comments

commented

The ASM patch PatchModifyEnchantmentLevels is causing a cross-mod interaction issue where some items begin to "flail" (see imgur link).

https://i.imgur.com/tIvN4ku.gifv

This appears to be because EncahntmentHelper.getEnchantmentLevel now has an NBT affecting side effect, leading to the animation reset.

I'm able to reproduce this issue with:

  • forge-1.12.2-14.23.3.2655-universal.jar
  • astralsorcery-1.12.2-1.8.9.jar
  • Baubles-1.12-1.5.2.jar
  • jei_1.12.2-4.9.1.172.jar
  • Mantle-1.12-1.3.2.24.jar
  • TConstruct-1.12.2-2.9.1.65.jar
  • EnderCore-1.12.2-0.5.20.jar

With those mods, a TiCon crossbow will flail. This is via an interaction with EnderCore's infinity enchantment tweak.
Disabling the EC tweak fixes crossbows (by eliminating the call to getEnchantmentLevel), but there are other things affected like the Redstone Arsenal flux bow.

commented

For others with same issue, confirmed during discussion on Discord server that in-dev fixes have already resolved this, with confirmation on latest build.