[Infernal Mobs] Crash upon killing an Infernal Zombie

Question

[Infernal Mobs] Crash upon killing an Infernal Zombie

katubug opened this issue 5 years ago · 2 comments

katubug commented 5 years ago

An Infernal Zombie spawned inside a Roguelike Dungeon, and one of my players killed it. As soon as it died, the entire server crashed.

Here's the report: https://pastebin.com/AS20ihJF

InfernalMobs Version: 1.7.6 according to changelog
Forge Version: forge-1.12.2-14.23.5.2838-universal

AtomicStryker · Answer 1 · 2019-06-05T06:00:09.000Z

The crash is not related to Infernal Mobs in a way that i could see. From what i can trace, for some reason this EntityZombie registers as "EntityTameable" (this is not vanilla and must be the work of a different mod, a coremod even) which makes vanilla code run into the above error.

More technically:
In EntityAIHurtByTarget#alertOthers
the expression
"!entitycreature.isOnSameTeam(this.taskOwner.getRevengeTarget())"
with entitycreature being a different EntityZombie (which for some reason is an EntityTameable) and taskOwner being the attacked EntityZombie. Now, the implementation of Entity.isOnSameTeam relies on the parameter to not be null, however EntityZombie always returns null for getRevengeTarget()

katubug · Answer 2 · 2019-06-05T11:18:39.000Z

Thank you very much for laying that all out for me. I'll look into my modlist and see if there's anything that tames hostile mobs, that might be the culprit. Thanks!

…

On Wed, Jun 5, 2019, 1:00 AM AtomicStryker ***@***.***> wrote: The crash is not related to Infernal Mobs in a way that i could see. From what i can trace, for some reason this EntityZombie registers as "EntityTameable" (this is not vanilla and must be the work of a different mod, a coremod even) which makes vanilla code run into the above error. More technically: In EntityAIHurtByTarget#alertOthers the expression "!entitycreature.isOnSameTeam(this.taskOwner.getRevengeTarget())" with entitycreature being a different EntityZombie (which for some reason is an EntityTameable) and taskOwner being the attacked EntityZombie. Now, the implementation of Entity.isOnSameTeam relies on the parameter to not be null, however EntityZombie always returns null for getRevengeTarget() — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#264?email_source=notifications&email_token=AE7XE5XDNI42BEIE3HJUOPTPY5I6VA5CNFSM4HTHLQQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW6V4ZQ#issuecomment-498949734>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE7XE5VYQZIHNNBLW2ACUL3PY5I6VANCNFSM4HTHLQQQ> .

Share to