Auth Me

Auth Me

Mods
6M Downloads

Add configurable browser CLI arguments when opening links

DespairScent opened this issue ยท 1 comments

commented

Is your feature request related to a problem?

I'm using many browser profiles, and there is only one with Minecraft (Miscrosoft) account. When I log in via AuthMe, it directs me to the last opened (last used?) profile browser window, which is not always the right one. Most time, I first need to open the browser profile with the game account and only then click the AuthMe button. It's not very convenient.

Describe the solution you'd like.

Add config entry to specify command that runs browser. For example, google-chrome --profile-directory=ProfileWithMinecraftAccount

Describe alternatives you've considered.

.

Agreements

  • I have searched for and ensured there isn't already an open issue regarding this.
  • I have ensured the feature I'm requesting isn't already in the latest supported mod version.

Other

.

commented

Hi, this is a neat idea to include, I can see how this could impact people using multiple profiles. Thanks for raising!

Just noting the affected lines of code where we would need to pass the optional parameters to -

authme/src/main/java/me/axieum/mcmod/authme/api/util/MicrosoftUtils.java

Line 94 in 9293bc6

return acquireMSAuthCode(url -> Util.getOperatingSystem().open(url), browserMessage, executor);

Something to consider would be compatibility with non-chromium based browsers. But as you suggested, we can leave the browser flags blank by default, and the user can configure it as --profile-directory=OtherProfile to their browser's needs.