Why does the item filter have so many items that aren't even in the fishing loot tables?
Jeanfeels opened this issue · 2 comments
Is your feature request related to a problem? Please describe.
In vanilla minecraft, there are a total of 23 unique fishable items, excluding the enchanted versions of fishing rods, at time of writing.
So, showing a list of all items and forcing people to search through it to filter out items kinda seems like a pointless waste of processing power and makes the user experience frustrating when attempting to filter items.
Given the sheer number of items in vanilla minecraft that aren't in the loot table even without mods, I am honestly baffled by this choice as the only possible benefit i can see is for mods that add fishable items to the loot table, which should not be the default assumption to make.
Even then, unless those mods add every single item in the game, which would be incredibly silly, it still means that trying to select specific items is like trying to find a needle in a haystack. It is frustrating in the extreme and involves memorising the list of items you want to filter out, at least the first time.
Describe the solution you'd like
By default the item filter configuration should show a static list of all possible, vanilla fished items based on the wiki (https://minecraft.fandom.com/wiki/Fishing#Junk_and_treasure), which users should be able to toggle on or off in the same way as currently.
From there, additional items could be added to this list manually using the current search feature for folk with mods that alter loot tables or add new fishable items, since that is obviously an important function to retain for compatability with other mods. It should not be the default experience, however.
Describe alternatives you've considered
An alternative might be to find a way to, within java, detect changes to the fishing loot table made by other mods and maybe even fetch the full list from the game files. I am not sure if this is even possible, but it would cut out a ton of manual work for mods that add a lot of fishables.
Additional context
Regardless of all the above though... Dude, you have no idea how much i was longing for a mod that made afk fishing viable again. Thank you for your efforts. ♥
This is done because mods might add fished items directly from an event, but not the loot table, so just by checking the loot table might not be enough.
I have another solution though, which is to put items in the loot table to the front of the selection screen. In this way, users won't have to use search in most case.