[Bug/漏洞] Players without Infinity Boots equipped randomly jump higher
embermctillhawk opened this issue · 2 comments
Checks / 检查
- I confirm that I have searched for existing issues / pull requests before reporting to avoid duplicate reporting./我确认在报告之前我已经搜索了现有的问题或者拉取请求，以避免重复报告。
- I confirm that I followed the Docs and read the Changelog, but this problem still exists./我确认我按照文档配置并阅读了Changelog，但这个问题仍然存在。
- I confirm that I noted that if I don't follow the instructions, the issue may be closed directly./我确认我已经检查，如果我不按照说明进行操作，该问题可能会被直接关闭。
Java Version / Java版本
17.0.7
Minecraft Version / Minecraft版本
1.20.4
Avaritia-Reforge Version / Avaritia-Reforge版本
1.3.5.3
Description / 描述
Players without Infinity Boots equipped jump higher every other game tick.
This is because every game tick, committee.nova.mods.avaritia.init.handler.AbilityHandler adds every player without Infinity Boots which is not in the entitiesWithBoots to that HashSet and removes every player without Infinity Boots who is in that HashSet. Therefore this effect happens every other tick.
The jumpBoost event is processed for all players and checks if they are present in that HashSet. Players without Infinity Boots equipped are present in that HashSet every other tick, therefore every player will jump higher every other tick without Infinity Boots.
Players with Infinity Boots equipped do not experience such a bug. No other armor effect seems to trigger without the armor equipped, only the Infinity Boots jump boost every other tick.
To Reproduce / 重现
Do not equip Infinity Boots, and jump on random ticks. Holding jump takes an even number of ticks so you can't hold jump, it has to be random.
Log / 日志
Config / 配置
default (fresh instance made exclusively to test)
