[1.6.2] Sky color transition being weird

Question

[1.6.2] Sky color transition being weird

Closed this issue a year ago · 27 comments

Rad586 commented a year ago

1.5.0
https://github.com/ItsThosea/BadOptimizations/assets/99306685/1e82b7c5-9ba9-498f-87bc-ac97169e2b05

1.6.2
https://github.com/ItsThosea/BadOptimizations/assets/99306685/8dd9076d-72ea-4d9e-a1cb-59f5c29c3dde

I know it may be what "sky color caching" is intended to do, but it really breaks immersion.

imthosea commented a year ago

i win

😄1

Rad586 commented a year ago

Yes

imthosea · Answer 1 · 2024-01-10T12:00:49.000Z

Do you have any another mods that affect the sky?

Also, I'm most likely blind, but I can't tell the difference between both clips.

Rad586 · Answer 2 · 2024-01-10T12:39:30.000Z

Here I made a better comparision:
https://github.com/ItsThosea/BadOptimizations/assets/99306685/b8eb174e-81cb-40de-8b62-7672d1fbe0be
For example, 1.5.0(or vanilla) is like counting 1, 2, 3, 1.6.2 is like 1, 4, 7.
I tested with only bad optimizations, the issue still exists. The sky color is modified via datapack.

imthosea · Answer 3 · 2024-01-11T01:13:12.000Z

Ok-sorry for asking so many questions but is this on a biome border where both biomes have different sky colors? Or is it just normal gameplay?

Rad586 · Answer 4 · 2024-01-11T04:32:24.000Z

It's on the biome border

imthosea · Answer 5 · 2024-01-12T04:39:16.000Z

Does this slightly modified 1.20.2-1.20.4 version fix your issue?

Rad586 · Answer 6 · 2024-01-12T19:17:24.000Z

Unfortunately not

TinyGamesCoding · Answer 7 · 2024-01-13T04:41:01.000Z

maybe if there isn't a solution for this, there could be a config that allows for enabling/disabling certain optimizations, like this one?

imthosea · Answer 8 · 2024-01-13T17:22:05.000Z

Unfortunately not

Attempt two, try this

If that doesn't work I've got one more idea in my head but I don't like it...

Rad586 · Answer 9 · 2024-01-13T17:30:43.000Z

Well, it didn't work either

imthosea · Answer 10 · 2024-01-13T17:31:44.000Z

im pulling all the strings for this one
but before, i must ask: how big in blocks is the radius of the sky color transition between biomes?

Rad586 · Answer 11 · 2024-01-13T17:40:24.000Z

I tested in game, it's about 12 blocks

imthosea · Answer 12 · 2024-01-13T17:40:44.000Z

thank you, give me a second

imthosea · Answer 13 · 2024-01-13T17:50:35.000Z

ignore that previous thing i deleted lmfao
so as i was saying fourth times the charm

Rad586 · Answer 14 · 2024-01-13T17:55:43.000Z

That works! The transition is much smoother now

imthosea · Answer 15 · 2024-01-13T17:56:29.000Z

That works! The transition is much smoother now

much smoother? wait so is there still a difference

Rad586 · Answer 16 · 2024-01-13T17:57:06.000Z

Yep, vanilla is smoother

imthosea · Answer 17 · 2024-01-13T17:57:55.000Z

Yep, vanilla is smoother

I'm lowering the threshold one sec

imthosea · Answer 18 · 2024-01-13T18:03:21.000Z

is this smoother

Rad586 · Answer 19 · 2024-01-13T18:05:51.000Z

Yeah, I can't tell the difference now

imthosea · Answer 20 · 2024-01-13T18:28:03.000Z

Yeah, I can't tell the difference now

I made more some changes, is it still good?
mod.zip

TinyGamesCoding · Answer 21 · 2024-01-13T18:49:15.000Z

you're did it :D

imthosea · Answer 22 · 2024-01-13T23:53:20.000Z

LAST TIME I PROMISE

Rad586 · Answer 23 · 2024-01-14T05:50:55.000Z

Yeah, it's working perfectly
Sorry for the late reply, I just went sleep

imthosea · Answer 24 · 2024-01-15T06:07:20.000Z

Sorry for a late response, 1.19.3 port was being annoying (took me 5 hours to find the one line of code :/) and @TinyGamesCoding was distracting me with bedwars
Anyway 1.6.3 is now out

TinyGamesCoding · Answer 25 · 2024-01-15T06:07:52.000Z

can confirm, we won games 😎

Share to