Breaks player persistent data in kubejs
Rad586 opened this issue ยท 9 comments
So this is a bug happening only in edge cases.
I installed bad optimizations 1.6.3 in my modpack, and found it clearing player persistent data after death, causing it behaving falsely.
I dichotomized the mods to find the problem, and found 11 mods relating to this bug, and bad optimizations is playing the essential role(once you delete bad optimizations, it works normally).
I tested multiple versions of bad optimizations, and it turns out any version higher than 1.3.1 breaks persistent data.
Player persistent data stores in player data. "Breaking" here means when player died, his persistent data was cleared, returning "undefined".
Full mod list: https://gist.github.com/Rad586/0e2bb2989c989b0c58d98ea925e7101a
11 mods:
stacker
better climbing
faster tools
spoorn armor attributes
bedrockify
variable spawner hardness
save gear on death
progressive bosses
easy magic
universal enchants
shulker loader
Are there any mods that modify KubeJS? Cause I just checked its mixins and none seem to conflict with BadOptimizations (i may be blind).
I still can't find any mixin conflicts, what's the persistent data feature of this mod anyway, and how do you use it? Is there a specific name for it?
I don't know exactly how this feature works, but I think it's something writes into player data, and check it when needed.
I used persistent data to make a recovery pearl, which teleports players to their last death point.
Here's my script:
//Get the coordinates of death point
EntityEvents.death("minecraft:player",event =>{
let pData = event.entity.persistentData
pData.deathx = event.entity.x.toFixed(0)
pData.deathy = event.entity.y.toFixed(0)
pData.deathz = event.entity.z.toFixed(0)
//
event.entity.stages.add('dead')
//Teleport to other dimension(if needed)
if (event.entity.level.dimension == 'minecraft:overworld') {
pData.deathdimension = 1
}
if (event.entity.level.dimension == 'minecraft:the_nether') {
pData.deathdimension = 2
}
if (event.entity.level.dimension == 'minecraft:the_end') {
pData.deathdimension = 3
}ItemEvents.rightClicked("kubejs:recovery_pearl",event => {
let pData = event.player.persistentData
//Cancel teleport if player has already get to the place
if(!event.player.stages.has('dead')) {
event.player.statusMessage = Text.translate('dialouge.fmn.tp1');
event.cancel()
}
event.player.stages.remove('dead')
//Teleport player to their death point
if (pData.deathdimension == 1){
event.server.runCommandSilent(`execute in minecraft:overworld run tp ${event.player.username} ${pData.deathx} ${pData.deathy} ${pData.deathz}`)
}
if (pData.deathdimension == 2){
event.server.runCommandSilent(`execute in minecraft:the_nether run tp ${event.player.username} ${pData.deathx} ${pData.deathy} ${pData.deathz}`)
}
if (pData.deathdimension == 3){
event.server.runCommandSilent(`execute in minecraft:the_end run tp ${event.player.username} ${pData.deathx} ${pData.deathy} ${pData.deathz}`)
}
//Gives resistance effect, cost one item
event.player.potionEffects.add('minecraft:resistance', 100, 4)
event.item.count--
})